search

blocktronics / moebius

Modern ANSI & ASCII Art Editor
https://blocktronics.github.io/moebius/
Apache License 2.0
734 stars 40 forks source link

SAUCE comments #165

Closed bart-d closed 3 years ago

bart-d commented 3 years ago

After clarification of the SAUCE spec author, some corrections are required in the Moebius implementation of SAUCE commentlines (more details here: https://github.com/16colo-rs/16c/issues/67#issuecomment-706572807)

  1. the amount of comment lines stored in SAUCE needs to be rounded up currently it's not rounded which may skip parsing the first line.
  2. SAUCE commentlines needs to be split or space padded at the end up to 64 characters, in the representation, they should be seperated by newlines.
bart-d commented 3 years ago

Draft: PR https://github.com/blocktronics/moebius/pull/166

It could be helpful if the new behavior could be tested, the mac and windows portable builds below contain the fixes:

https://16colo.rs/tmp/moebius-commentlines/Moebius.dmg https://16colo.rs/tmp/moebius-commentlines/Moebius.exe