search

blockwise-direct-search / bds_matlab

Blockwise Direct Search (MATLAB version)
GNU General Public License v3.0
1 stars 1 forks source link

Correct the English #45

Closed zaikunzhang closed 1 year ago

zaikunzhang commented 1 year ago

https://github.com/blockwise-direct-search/bds/blob/85ad91015f809cb69a354e3555a382ed2860f94e/src/private/inner_direct_search.m#L117-L119

In terms of grammar, "there is some case where" should be "there are some cases where". However, logically, it does not work. It should be "there may be cases where", or better, "it may happen that".

"as long as ..., then" does not work.

Lht97 commented 1 year ago

115th line on inner_direct_search.m

Lht97 commented 1 year ago

Explain the situations more specifically. Use the comment above to describe the situations.

Lht97 commented 1 year ago

I have modified the comment of https://github.com/blockwise-direct-search/bds/blob/00e99a8454ad3a0bf0facb078128b117cd33925a/src/private/inner_direct_search.m#L140.