search

blockwise-direct-search / bds_matlab

Blockwise Direct Search (MATLAB version)
GNU General Public License v3.0
1 stars 1 forks source link

I do not understand these files #82

Closed zaikunzhang closed 1 year ago

zaikunzhang commented 1 year ago

I think something is seriously wrong with the following files. Otherwise, they should not exist at all.

https://github.com/blockwise-direct-search/bds/blob/main/tests/competitors/matlab_fminsearch.m https://github.com/blockwise-direct-search/bds/blob/main/tests/competitors/matlab_fminunc.m

In particular, where and how did you set options for these solvers? Don't you need to translate the options so that the solvers understand them correctly?

Similar questions should be asked about the following file:

https://github.com/blockwise-direct-search/bds/blob/main/tests/competitors/matlab_patternsearch.m

This makes me doubt the correctness of all comparisons involving these three solvers --- and I am also worried about other solvers.

If you do not understand what I am talking about, ask @Tom or @Cunxin.

Lht97 commented 1 year ago

I have removed those files and use fminsearch and fminunc directly. But for my understanding, those files can be regarded as wrappers. I will check the difference between these two situations. Thanks for your advice.

Lht97 commented 1 year ago

I have made every competitor has its own wrapper to deal with the common options.