blockworks-foundation / mango-ui-v3

Mango Markets V3 UI
https://trade.mango.markets
GNU Affero General Public License v3.0
84 stars 114 forks source link

save profile images to our db #387

Closed saml33 closed 1 year ago

saml33 commented 1 year ago

Makes loading and saving nft profile pics faster.

this beaks existing profile pics so anyone who has one will need to redo

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
mango-ui-v3 ✅ Ready (Inspect) Visit Preview Aug 4, 2022 at 10:34AM (UTC)
mango-ui-v3-devnet ✅ Ready (Inspect) Visit Preview Aug 4, 2022 at 10:34AM (UTC)
mango-ui-v3-testnet ✅ Ready (Inspect) Visit Preview Aug 4, 2022 at 10:34AM (UTC)
github-actions[bot] commented 1 year ago

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 835.77 KB (🟢 -11.69 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (500 KB)
/account 176.23 KB 1012 KB 202.40% (🟡 +0.03%)
/leaderboard 3.24 KB 839.01 KB 167.80% (+/- <0.01%)
/profile 190.68 KB 1 MB 205.29% (🟡 +0.03%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

mschneider commented 1 year ago

Would introduce a lot of friction if people would still need to re-select their profile pics. Might loose trust in the feature all together and not bother with setting it up again.

Is there a way we can pre-seed the db with the current avatar selections?

saml33 commented 1 year ago

@mschneider Nick said we can seed the db so we can put this on hold until then. FYI this makes the loading nfts part faster too