Using ipsn/go-secp256k1 package ended up being a mistake... Trying to build the package in a library which also used go-ethereum would cause cgo build conflicts and a whole lot of mess... The fix is easy: just remove all the code for signing and let people bring their own signing code. For compatibility, this is probably our best bet. This also allows for external signing (ex: hardware wallets).
yihau
commented
2 years ago
Using
ipsn/go-secp256k1package ended up being a mistake... Trying to build the package in a library which also usedgo-ethereumwould cause cgo build conflicts and a whole lot of mess... The fix is easy: just remove all the code for signing and let people bring their own signing code. For compatibility, this is probably our best bet. This also allows for external signing (ex: hardware wallets).