Minor fixes - Githubissues

blogifierdotnet / Blogifier

Blogifier is an open-source publishing platform Written in ASP.NET and Blazor WebAssembly. With Blogifier make a personal blog or a website.

https://blogifier.net

MIT License

1.26k stars 518 forks source link

Minor fixes #274

Open farzindev opened 3 years ago

farzindev commented 3 years ago

[x] Return URL Return URL is not working, After we log in, It goes back to the dashboard. http://localhost:5000/admin/login/?returnUrl=http://localhost:5000/admin/profile/
[x] Register When we start fresh it goes to the /admin/ instead of /admin/register/
[x] Page URL There shouldn't be a /posts/ before the slug of the page. It should be: http://example.com/title-of-the-page
[ ] Default Cover Add the default cover back to the settings, so that admin can change the default cover.
[ ] Localizer on the themes not working, please check.
[x] Search bug When we search in the blog posts, we see results from pages as well. they need to be separated completely.

Add more minor details that are left to do here.

fullreboot commented 2 years ago

Alright sorry about all the mess, this pull request will fix # 3 and # 6 from the list above.

Had to do some small hackery to make sure we weren't hijacking the /admin route from razor

https://github.com/blogifierdotnet/Blogifier/pull/295

farzindev commented 2 years ago

@fullreboot Thank you, we review it this week.

fullreboot commented 2 years ago

@farzindev

I found another small bug in my pull request. For some reason routing of /admin or /admin/ gets routed differently. Sometimes it get "stolen" by MVC home controller.

Maybe you guys have a better idea of why routing is broken?

fullreboot commented 2 years ago

The bug previously mentioned has been fixed and is pushed to the PR. If this is an unacceptable hack please let me know.

https://github.com/blogifierdotnet/Blogifier/pull/295#issuecomment-919416003

farzindev commented 2 years ago

Hey @rxtur, Please review this, Thank you.

chatay commented 2 years ago

hello @farzindev, I am going to look at the second issue. You mean, when one enters the website, register page should be the first initial page appears?

@fullreboot 3. and 6. issues have been resolved?

fullreboot commented 2 years ago

@chatay 3 and 6 are resolved.

2 doesn't seem to be an issue for me, it will correctly redirect me to register if DB is missing on app startup

farzindev commented 2 years ago

@chatay it seems it's working fine.

oleksiivasylenko commented 2 years ago

Hi, I see several more small issues.

1) When I logged in into admin panel and switching tabs(dashboard/blog/pages...) after once clicking on 'pages' the tooltip icon is always show under 'pages' and 'blog' tabs until refresh page.

2) Create new 'page', save it, then publish it and go to that page. On that page cover image is broken 'src="//http://localhost:3169/img/cover.jpg"'

ismaelmiah commented 1 year ago

@farzindev the default cover image is showing, but this picture should change after clicking on it. I think this feature has bugs.