blogtutor / blog-tutor-support

Custom Support Plugin for NerdPress Clients
6 stars 3 forks source link

Our HelpScout beacon conflicts with Yoast's & WPForms' #269

Open blogtutor opened 1 year ago

blogtutor commented 1 year ago

image

CNoemi94 commented 3 months ago

From Sergio: "It now doesn't show their beacon, but will open ours when you select their "ask support" or such button."

ecotechie commented 3 months ago

This shows in the free version, and the problem stands as is.

For the Premium version. the beacon button isn't an issue as it does not show up. Buut then the Contact our support team button triggers our beacon, not theirs. image

blogtutor commented 3 months ago

Should we just not load our Help Scout script at all on these page(s)? If so, we'd need to remove our "Get Help" link in our top admin dropdown menu, too.

halounsbury commented 2 months ago

Ah, we should get this fixed. I would say not load on these pages and remove the top link on these pages too, yes.

ecotechie commented 2 months ago

Have we reached out to HelpScout about this? It will continue to be an issue. More and more, as other plugins use their beacon.

CNoemi94 commented 2 months ago

My thoughts on this and all the others related (#270 & #267) is to set a standard of where our HelpScout Beacon is available so it doesn't conflict with other plugins.

Since we don't currently have a settings page, we can choose to show our HS beacon on default WordPress dashboard pages and no others, so

CNoemi94 commented 1 month ago

@halounsbury @ecotechie, what do you think of specifying which pages to show our HS beacon on instead of showing it everywhere?

halounsbury commented 1 month ago

I think that's a good idea.

blogtutor commented 1 month ago

I think if it's on every (or nearly every) default WP page this would work. That'll be a pretty long list to compile, but I suppose quite doable.

Unless we can do this for top-level categoryes (like, "All Settings"). But a lot of plugins add their pages as sub-pages in Settings, for example, so if we do it for all "Settings" screens it'll still include those.

blogtutor commented 1 month ago

Do we have any data on what URLs people are most often on when they click the button?

CNoemi94 commented 1 month ago

Do we have any data on what URLs people are most often on when they click the button?

@halounsbury @ecotechie Do either of you know if we're collecting this data somewhere?

I know it's included in the HS ticket when they send us a message through it.

ecotechie commented 1 month ago

What if we check to see if the beacon is already loaded and stop our process? Not sure I would want to take the approach of having some standard pages we show it on, since plugins can still decide to show the beacon wherever they want, not just their home page.

blogtutor commented 6 days ago

Mike Z just reported a similar conflict with WP Forms on https://boulderlocavore.com/wp-admin/admin.php?page=wpforms-settings&view=integrations

https://nerd-press.slack.com/archives/C03SMSFN67Q/p1723745368019629

image