search

blogvault / wpcom-migration

Migration Plugin for WordPress.com Migrations
0 stars 0 forks source link

BlogVault White-labelled plugin: Add JS to show/hide the cancel-migration modal #16

Closed markbiek closed 3 weeks ago

markbiek commented 3 weeks ago

Screenshots

Desktop:

CleanShot 2024-08-26 at 14 09 25@2x

Mobile:

CleanShot 2024-08-26 at 14 09 45@2x

Testing Instructions

  1. Download and install the plugin. You could use jurassic.ninja for a quick environment setup.
  2. Go to /wp-admin/admin.php?page=automattic&static=migration-progress.
  3. Compare the page to the design. Having small differences should be fine, IMO.
  4. Make sure it looks good on mobile and the different browsers.
fditrapani commented 3 weeks ago

This is looking great! thanks Mark. One minor thing is that on small breakpoints, the modal doesn't shrink to fit the viewport. Anything under 420.

You should be able to fix this by updating .wpcom-migration-modal's width to 100% and adding a max width of 424px. In addition to that, we'll need to add gap: 16px to .wpcom-migration-modal-buttons.

markbiek commented 3 weeks ago

@fditrapani That's updated now.