search

blokadaorg / blokada

The official repo for Blokada apps.
https://blokada.org
3.06k stars 215 forks source link

Blokads is blocking downloads that use the Android Download Manager service #324

Open thanuj10 opened 5 years ago

thanuj10 commented 5 years ago

This is a very critical bug that needs to be fixed. Any app or that uses the Android Downloads manager is blocked by blokada and i do not know why it does it. Download Manager is already added in the app whitelist. This mostly happens with browsers that use WebView and depend on androids download manager for downloads. Chrome and Firefox and browsers that use their internal download manager is not affected.

Steps to reproduce

  1. Open Via or similar browsers.
  2. Download something.
  3. Download does not start.

Expected behaviour

Downloads must start and finish.

Actual behaviour

Downloads do not start and nothing is added to the download queue. Once Blokada is stopped and download reatarted, Download starts and resumes normally.

Configuration

  1. Blokada version - 3.6 (Latest Release)

  2. Device model - Nokia 6.1 Plus

  3. Android version / ROM - Android 9.0/Pie

Questions

  1. How long have you been using Blokada? About a year

  2. How long time ago has the problem started to happen? Almost always, never reported.

  3. How often does this problem happen to you? Everytime i download something.

peterroth commented 5 years ago

Hi,

Thanks for reporting it. Are you use the download doesn't start? If you want, doesn't your phone report that the download finished? The package com.android.providers.downloads.ui isn't whitelisted, this is the user interface of the com.android.providers.downloads package. Can you try to add the earlier to the whitelist and test the behaviour again?

The criticality of a bug depends on a lot of factors. This is not critical and not yet identified as a bug.

thanuj10 commented 5 years ago

Yes i'm very sure the download does not start. For more clear instructions on repo the bug -

  1. Download Via or Firefox Lite(i tested both, Via is bit more easier to work with)
  2. Download any file, I tried downloading Bromite.apk and Firefox Fenix from Github and Taskcluster respectively.
  3. Starting download shows a prompt on the screen indicating the download has started, but there is no notification or the download isnt added to the download list in downlaods app.
  4. Checking the browsers downloads page i get this - Firefox Lite - Nothing is shown Via - A download is shown, but the filesize is shown incorrect (0bytes of -1.0bytes).
  5. Turning of blokada makes the browser(s) resume the download.

Ill try whitelisting the app you mentioned above, Thanks.

EDIT - I've whitelisted the app you mentioned. The app exhibits the same behaviour.

ghost commented 5 years ago

Let us know as if its that simple,the UI needing a whitelisting,that could be defaulted if needed. Also can confirm at least with the LineageOS default,this used to baffle me that downloads never worked but I figured try later. Thought it was just me!

peterroth commented 5 years ago

@thanuj10 could you elaborate on the "The app exhibits the same behaviour."?

thanuj10 commented 5 years ago

@rpeter85 i meant that the app still blocks downloads after whitelisting com.android.providers.downloads.ui

larabih commented 5 years ago

I confirm the same incident. I use Firefox Focus and when I download a file, the download start icon appears briefly and disappears immediately. I disable Blockada and re-download the file and then everything works fine. the same behavior occurs when I use webview applications such as Frost for facebook

Configuration

Questions How long have you been using Blokada? since the version 2.x.x

How long time ago has the problem started to happen? when i was on LineageOS 15 and now on /e/ system

How often does this problem happen to you? Everytime i download something

peterroth commented 5 years ago

Can you tell me which browser do you face the issue with? Firefox Focus, is there another one?

thanuj10 commented 5 years ago

Im my case all webview based apps and browsers have this problem. Via, Firefox Lite, Firefox Focus.

larabih commented 5 years ago

@rpeter85 : Browsers:

Apps

thanuj10 commented 5 years ago

As i said before, Browsers with an internal download manager work fine. But Webview based apps do not download stuff.

matteocoder commented 5 years ago

Can the issue be caused by this bug? @thanuj10 Do you have any devices with Android 6 or earlier to see if you can reproduce the issue?

thanuj10 commented 5 years ago

Yeah i do actually. Ill try reproducing the bug devices with android 6 or earlier.

Side note - This bug exists on Android 7.1.2 also

Edit - Went through the bug link posted above. Seems like an Android Problem :(

racuna commented 5 years ago

Same here, MIUI 10, Android 8.1

thanuj10 commented 5 years ago

Seems like other adblockers that use similar mechanism like Blokada allow downloads through android's download manager when whitelisted.

Source - Adgaurd and DNS66 both allow downloads when android's download manager is whitelisted.

Seems like a problem with the default whitelist, maybe in the next update let blokada whitelist all system apps by default?

peterroth commented 5 years ago

In v4, system apps can be whitelisted as well :)

thanuj10 commented 5 years ago

Ah, then the problem might be sorted. Excited for v4's release!

Buntbart commented 5 years ago

Same here: LOS 16 without GApps, Browsers: Lightning, Firefox Klar, Privacy Browser, FOSS Browser. All fail to start downloads when Blokada is active

larabih commented 5 years ago

@rpeter85

In v4, system apps can be whitelisted as well :)

If apps can be whitelisted, blokada will not block ads domains from this apps or I misunderstood ?

thanuj10 commented 5 years ago

@larabih yes whitelisting will allow ads to show. But generally speaking, system apps do not show ads.

thanuj10 commented 5 years ago

Can i ask about the progress on this issue? Im forced to use other adblocking apps as this blocks download manager and i use it alot..

larabih commented 5 years ago

@thanuj10 This problem was confirmed on the ROM LineageOS. Personally I use firefox to open download links instead of Firefox Focus which I usually use.

Herbstfreud commented 5 years ago

I opened this as Issue #209 already. Seems to be a kind of restriction in Android itself.

A browser which can handle downloads with Blokada enabled is Fennec, also available at F-Droid.

ikanakova commented 5 years ago

Same problem here (Blokada 3.7 installed from F-Droid, on Android 9 / Nokia 6.1 / Android One, Firefox Focus 8.0.11 installed from Google Play) - cannot download files, but without Blokada it works (tested on Nokia 5 with same Firefox Focus).

peterroth commented 5 years ago

Can you let me know what exactly should be whitelisted to be able to download things? I want to add that to default whitelist.

Herbstfreud commented 5 years ago

There is something that can be whitelisted for that? This would be really interesting - I haven't seen anything for this.

Or is there some type of alternative download manager or alternative webview engine that can be installed?

soredake commented 5 years ago

Any progress on this?

thanuj10 commented 5 years ago

@rpeter85 I've seen some other VPN Based adblockers whitelist the Download Manager app by default.

SeriousHoax commented 5 years ago

I face the same problem too. Happens on Firefox Focus and a third party twitter app that I use named, Flamingo for twitter. Download manager is whitelisted but still this happens. I'm forced to use another adblocker at the moment. Seen some version 4 screenshots and seems like finally it's gonna have everything we want feature wise. Hopefully a solution for this problem would be found before the release of version 4.

thanuj10 commented 5 years ago

Problem still not fixed in V4.

SeriousHoax commented 5 years ago

Well, version 4 got released today! Didn't notice. This problem needs to be fixed soon.

peterroth commented 5 years ago

Do you guys know what is the cause? As it currently seems a system app is blocked, and they can be whitelisted in v4. Did you try that?

thanuj10 commented 5 years ago

@rpeter85 the download manager service is already blacklisted by default. Also i added the download provider apk(The downloads app). No changes even after that.

kar commented 5 years ago

Is download manager working for you under Blokada VPN? Anyone tried?

kar commented 5 years ago

Also try enabling downloads on any network (not only wifi) in google play

thanuj10 commented 5 years ago

Downloads works from Google play regardless of the network connection type.

jleuwen commented 5 years ago

I have checked downloading when not on WIFI and this works over here. However Blokada is blocking the download (manager) when I am downloading while I am on WIFI. When I will disable Blokada, downloads can be done again on WIFI. I am running Blokada 4.3.5 on a Xiaomi Mi9T (Global standard Rom, MIUI 10.3.11).

kar commented 5 years ago

Anyone experiencing this problem, if you're on Telegram please reach out to me in priv.

Buntbart commented 5 years ago

Yes, same here. No Google Play Services installed, LineageOS 16 on klte. Downloads in Lightning-Browser do not work when connected via WIFI.

ghost commented 5 years ago

@Buntbart could you DM Karol on Telegram? 😉

Buntbart commented 5 years ago

I don't see why that should be necessary since he is able to read and write here and I don't use Telegram.

peterroth commented 5 years ago

To have a live discussion and not only messages in every half a day - 2 days. Easier to help that way.

afonari commented 4 years ago

This also affects downloading Apps on /e/: https://community.e.foundation/t/e-app-store-is-live/3803/10

jleuwen commented 4 years ago

I have checked downloading when not on WIFI and this works over here. However Blokada is blocking the download (manager) when I am downloading while I am on WIFI. When I will disable Blokada, downloads can be done again on WIFI. I am running Blokada 4.3.5 on a Xiaomi Mi9T (Global standard Rom, MIUI 10.3.11).

I can confirm that the latest version solves the issue. However, it was not working before deleting all the (system) apps from the exclusions and after that including them again. After including the download system app (2 times), all files will download also on WIFI. Good job.

Buntbart commented 4 years ago

No change in LineageOS 16 with Blokada 4.4.3 from F-Droid. Downloads are blocked when on Wifi. I excluded/included Download-Manager as described in the last post.

eXPerience83 commented 4 years ago

Can't download updates or apps from Xiaomi Store "GetApps" if I didn't whitelist it. And I can't see the blocked petition on the blockada log. I see that Xiaomi enables by default the "Secure DNS" and maybe this is the problem.

bigtreiber commented 3 years ago

I too have the same issue with Blokada 4.8.5 on Android 11 (OxygenOS). I tried excluding / including the "Download-Manager" on the whitelist but still can't download anything that is using webview :-(

SeriousHoax commented 3 years ago

I too have the same issue with Blokada 4.8.5 on Android 11 (OxygenOS). I tried excluding / including the "Download-Manager" on the whitelist but still can't download anything that is using webview :-(

Switch to NextDNS or Adguard DNS like I did.

tenzap commented 2 years ago

I'm facing that issue too on Xiaomi redmi note 9s, Android 11, blokada 5. I try to download fdroid app from fdroid website with duckduckgo app which then uses the built-in download manager. But download doesn't start.

Changing dns to adguard or using network DNS doesn't fix. Only way to get things downloaded is by disabling blokada.

tenzap commented 2 years ago

Since I don't know if this issue is followed, I just do a small @kar who seem to be in blokada team.

Btw what kind of additional input do you need for this issue?

As a addition to me previous comment, whitelisting these doesn't fix either: com.android.providers.downloads com.android.providers.downloads.ui