blokadaorg / blokada

The official repo for Blokada apps.
https://blokada.org
3.04k stars 213 forks source link

Minor Corrections for Description of My List (CPBL) #857

Closed bongochong closed 3 years ago

bongochong commented 3 years ago

I should have mentioned this a couple of weeks ago, but there's a minor grammatical error in Blokada's description of my list. It should read as: This list blocks malicious and harmfully deceptive content, like advertising, tracking, telemetry, scam, and malware servers. This list does not block porn, social media, or so-called fake news domains.

Currently it says These lists block in the first sentence, and These lists do not in the second sentence.

Additionally, it would be nice if you could add another sentence at the end: CPBL aims to provide block lists that offer comprehensive protection, while remaining reasonable in size and scope.

The relevant files appear to be:

Many thanks!

peterroth commented 3 years ago

Just for clarification: the lists do block also porn, social media and fake news. Right?

bongochong commented 3 years ago

They definitely do not block porn, social media, or so called fake news :[]

To clarify, it's just a grammatical error involving singulars and plurals, not an issue with the description of the list's characteristics.

peterroth commented 3 years ago

Ohh, ok, thank you for the clarification.

bongochong commented 3 years ago

No problemo!

bongochong commented 3 years ago

Oh yeah, and the slugline should read: A general purpose, medium weight list. Not lists.

bongochong commented 3 years ago

I just created one pull request to make it easier for you guys. Probably should have done that from the start. Sorry about that.

PR: https://github.com/blokadaorg/blokada/pull/859/

Edit: Initially created two requests, now all in one.