search

blokadaorg / blokada

The official repo for Blokada apps.
https://blokada.org
3.05k stars 215 forks source link

allow MainActivity to be shown in landscape mode #884

Closed jpstotz closed 3 years ago

jpstotz commented 3 years ago

This change allows users to use Blokada in landscape mode (see #833).

Tested on a 10" tablet.

kar commented 3 years ago

Sorry but I can't merge it, we disabled it on purpose, the UI is not adapted to all screen sizes to work in landscape. This would break small screen devices etc. More work would need to be done. If your change would only apply to tablet screens, then I could consider merging it.

jpstotz commented 3 years ago

@kar Would you accept a solution that does allow landscape mode if the screen size is e.g. larger than 9 inch screen in diagonal?

On a device with a smaller display Blokada would start with the "splash screen" (white background with Blokada logo and nothing more) in landscape mode (if the device is held this way). Then calculate the screen size and switch to portrait mode (device rotates) and finally switch to the "start fragment" (the one with the large power button).