blokadaorg / blokada

The official repo for Blokada apps.
https://blokada.org
3.04k stars 212 forks source link

Include more DoH Servers and correct some DNS values #887

Closed xopez closed 1 year ago

xopez commented 2 years ago

Again i have filled out some DoH servers. Someone has to double check, what I have changed since I am tired a bit. And I have a question regarding the digitalcourage dns configuration. Is it really needed to set the same IP two times? Since we speak if listOf it should only one be needed.

Fixes #836

xopez commented 2 years ago

Just saw this: https://github.com/blokadaorg/blokada/issues/836#issuecomment-790626521 I was probably to fast.

kar commented 2 years ago

Thank you for the PR. Indeed, we cannot merge it at the moment. We could if you split up the non-doh changes, like updated IPs. Although the trick here is that it'd be necessary to test out those configurations actually work before we merge..

Otherwise I'll leave the PR here for a while until we can get around the doh standard.

xopez commented 2 years ago

Thinking about the mass of commits in a PR, I'd like to leave it open like that so that we don't get confused there.