blokadaorg / blokada

The official repo for Blokada apps.
https://blokada.org
3.03k stars 212 forks source link

New error, despite not changing anything: "Your Private DNS setting is set. This may cause connectivity issues." #948

Closed e-t-l closed 1 year ago

e-t-l commented 1 year ago

Since Blokada 5 (F-Droid) updated to v22.3.8 three days ago, I've received the following popup error every time I open Blokada: "Ooops! Your Private DNS setting is set. This may cause connectivity issues. Please turn it off in Settings."

When I open the Private DNS android Settings page, I see it's set to Automatic. This is not something I've changed recently. The only recent change is that Blokada updates. Did this latest version change something to be more sensitive to Private DNS? Blokada seems to be continuing to handle traffic as usual.

I know in #503 we determined that Blokada will not work in conjunction with Private DNS on, but the "Automatic" setting (which seems to use DoT "when possible") seems to work just fine, as it appears to kick in for apps that have been whitelisted from Blokada.

-- One related issue I'm encountering is, while I have Cloudflare set as the DNS in Blokada, and (back when I had tried to set Private DNS to On) I had set Cloudflare set as android's DNS,* nevertheless when Private DNS is set to Automatic then OpenDNS is used to resolve domains.* This is almost certainly outside the scope of Blokada to fix, but it would be nice if there was a way to specify the DNS used by apps that are whitelisted in Blokada. (if I'm not explaining this well, see screenshot below for my current Private DNS settings. **I confirmed this using the free tenta.com/test DNS identifier service in Firefox Mobile, which is whitelisted in Blokada)

TLDR: Can someone confirm whether Blokada v22.3.8 changed something regarding Private DNS that is causing this popup? And can you confirm that my understanding of the relationship between Blokada, Private DNS, and whitelisted apps is correct?

Screenshot_20220922-102953

MorpheusUK commented 1 year ago

I've been getting exactly the same with f-droid v22.3.8 since the upgrade whether mine is set to off or automatic. I'm using a Samsung Galaxy S22

AIGeneratedUsername commented 1 year ago

I confirm the bug with:

AML44 commented 1 year ago

I confirm too installed from F-Droid i get this error but when i download the .apk from blokada.org i don't enconter this problem. Have you try to install from the official website ?

e-t-l commented 1 year ago

Have you try to install from the official website ?

No I haven't. Would it install as an update if it's the same version number, or would I have to uninstall blokada first?

@AML44 Interesting, and what are your Private DNS settings?

AML44 commented 1 year ago

For me i uninstall first the blokada application that i download from F-droid ans then i install the blokada dowbloaded from the original website. For the private DNS in my smartphone it's set in automatic.

e-t-l commented 1 year ago

Out of curiosity, what happens if you set Private DNS to On?

Sep 23, 2022 3:44:37 PM AML44 @.***>:

For me i uninstall first the blokada application that i download from F-droid ans then i install the blokada dowbloaded from the original website. For the private DNS in my smartphone it's set in automatic.

— Reply to this email directly, view it on GitHub[https://github.com/blokadaorg/blokada/issues/948#issuecomment-1256607864], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AJXDCFVHLKSR44DI5KQVYTLV7YB73ANCNFSM6AAAAAAQTEGRR4]. You are receiving this because you authored the thread.[Tracking image][https://github.com/notifications/beacon/AJXDCFXABDHIFOA7K6M3NILV7YB73A5CNFSM6AAAAAAQTEGRR6WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTSK4ZIHQ.gif]

AML44 commented 1 year ago

Dont know because i let the app in automatic mode

MorpheusUK commented 1 year ago

The issue does seem to be the f-droid build, downloaded the APK from the site and it doesn't have this issue.

JahidFariz commented 1 year ago

Yes, I'm having the same problem too.

Android Version: 12 Device: Samsung Galaxy S10 plus.

Except that everything works fine.

What should I do?

nieXas commented 1 year ago

Are we forced to uninstall f-droid version??

licaon-kter commented 1 year ago

F-Droid volunteers try to clean up source of proprietary library dependencies, see https://gitlab.com/fdroid/fdroiddata/-/commit/f325ad20b75ac91174cd996bc2b09c25460ab825

But since upstream is openly hostile to F-Droid fixes might not be perfect as if the devs would have separated the proprietary bits in a Gradle flavour so anyone can build a fully FOSS app.

kar commented 1 year ago

Thanks for reporting this. Sadly we do not maintain the f-droid listing anymore and don't have plans to do so. Blokada is open source so anyone is free to fork it and adapt if necessary. We recommend you to download the latest version from our website https://blokada.org.

licaon-kter commented 1 year ago

fyi https://gitlab.com/fdroid/fdroiddata/-/commit/51df6ec4eed02834ffdc2fa260a9320955cb11f2

e-t-l commented 1 year ago

@kar I'm actually still encountering this issue with this, using Blokada downloaded from Github...