search

blond-org / blond_common

Collection of common functions and interfaces
GNU General Public License v3.0
3 stars 5 forks source link

Definition of line density functions #24

Open alasheen opened 5 years ago

alasheen commented 5 years ago

In the fitting package, the binomial line density is defined as follow:

image

Should we go back to the original definition used in BLonD to stick with the beam dynamics convention:

image

or keep both conventions and handle the exponents from within an object ? The definition should then be propagated to all other related functions (parabolic, ...)

Issue open for discussion 👍

MarkusSchwarz1980 commented 5 years ago

I opt for the second version, mainly because of backwards compatibility: both the BLonD tracking code and cedar use the 'mu+1/2' convention. Also, with this convention the phase space density has a simple 'mu' as an exponent, which would need to be changed otherwise. In either case, the exponent for the line profile and phase space density must be compatible! Maybe this would be another job for BLonDrc: a global parameter that governs if the exponent should be used in the line profile or the phase space density.