search

blongho / worldCountryData

Android library for country flag, currency, and other country information
https://blongho.github.io/worldCountryData/doc/
MIT License
98 stars 35 forks source link

minsdk should be 21 #16

Closed chitgoks closed 4 years ago

chitgoks commented 4 years ago

hi correct me if im wrong

shouldn't min sdk be 21 instead of the current 15? there would be no point to have those vector images since it will still generate pngs.

blongho commented 4 years ago

I will make a patch with the minsdk 21. I think you are correct about the vector images.

chitgoks commented 4 years ago

thanks blongho!

blongho commented 4 years ago

Hi @chitgoks What is your experience with this

    implementation 'com.github.blongho:worldCountryData:ffa9b81b7c'

The only change there is upgrading the min-sdk to 21.

chitgoks commented 4 years ago

Hmm same result. weird. i have no idea why. i already set min sdk to 21 in my project and explicitly set vectorDrawables.useSupportLibrary to false

blongho commented 4 years ago

Evidently, changing the minSdk to 21 does not resolve your problem. I will close this issue

chitgoks commented 4 years ago

agreed