search

blongho / worldCountryData

Android library for country flag, currency, and other country information
https://blongho.github.io/worldCountryData/doc/
MIT License
98 stars 35 forks source link

Make classes "Country" and "Currency" Parcelable and fix spelling error in *Continent* Enum #36

Closed fatonhoti closed 2 years ago

fatonhoti commented 2 years ago

When trying to send for example a List<Country> from one activity to another via Intents, my application was crashing due to the fact that the class Country was not Parcelable. This pull request is my attempt to make the classes Country and Currency (Currency needs to be Parcelable too otherwise Country can't write Currency objects to it's Parcel) Parcelable in order to allow for the described functionality to work without crashing.

Furthermore I noticed a spelling error in the enum regarding the continents, so I fixed that.

blongho commented 2 years ago

Hi @fatonhoti thanks for your contribution. The feature has been successfully merged.

If there is additional feature that you want to include in the library, please free feel to make a pull request.

fatonhoti commented 2 years ago

@blongho Great, thank you! Are you planning on making a new release anytime soon so we can make use of the new feature? As of right now v1.5.1 does not have this feature.

blongho commented 2 years ago

Yes @fatonhoti , it is now v1.5.3.