search

bloody-green-tea / pubgapi

Java Wrapper for the PUBG API
GNU General Public License v3.0
8 stars 7 forks source link

Support for API V17.1.0 #4

Closed commana closed 4 years ago

commana commented 4 years ago

Thanks for providing this library!

I've noticed that recent changes to the PUBG API broke parsing of Telemetry events, so I made changes according the official changelog.

In addition, I added a test case to check if parsing the events works properly. By that, I realized they have reduced the PlatformRegion to just three choices. However, I didn't want to delete the old options since I didn't check if they are required elsewhere.

Let me know if you need additional information or changes.

bloody-green-tea commented 4 years ago

Thanks! There were many reasons I couldn't update the project, but I'm very grateful for providing this, can you give me some time to review this?

bloody-green-tea commented 4 years ago

As I reviewed it, there are some problems, but it is acceptable. I'll apply your source code