search

bloodybowlers / UkeGeeks-ng

Ukulele Songbook Website
GNU General Public License v3.0
6 stars 5 forks source link

More Chordpro directives #18

Open bloodybowlers opened 5 years ago

bloodybowlers commented 5 years ago

More Chordpro directives support :

louis-coding commented 5 years ago

And perhaps add support for other ChordPro directives as well, e.g. key, time, tempo - and include all that in #13

In any case keep it compatible to ChordPro specs.

bloodybowlers commented 5 years ago

Thanks for the ChordPro specs link :) I like the "capo" one ! Key would be cool to show the original key to the user too...

louis-coding commented 5 years ago

Well, a song in C with capo in 2 is effectively in D, but still played with the C chord shapes.

So consequently the key value must be the sum of transposition steps (+ or -) and capo value. _keyoriginal sounds like another meta candidate (if at all necessary)

BTW: Have you ever had a closer look at the UkeGeeks fork of Jim's Songbook? Awful lot of great modifications in there...

bloodybowlers commented 5 years ago

I didn't knew the site Jim's Songbook, thank you. There's a lot of content :) The guy made a website from scratch and is using the scriptasaurus engine, customised. That's cool. And a huge work !

Honestly, this is the best way to do it, instead of hacking the code like I do currently... It's way cleaner... Sadly I don't have a lot of time to work on it so, I'll continue hacking the features I need ^^

bloodybowlers commented 5 years ago

I'll add the capo directive soon (tm).

It's just used for display and doesn't change the key, as specified here : https://www.chordpro.org/chordpro/Directives-capo.html

I'll like to add a custom meta tag for strumming pattern too. Like :

{meta: strumming DD-UU-D-U}

bloodybowlers commented 5 years ago

Key added.

Next one will be tempo...

bloodybowlers commented 5 years ago

Important note about the tempo directive :
Multiple specifications are possible, each specification applies from where it appears in the song.
(from chordpro website)

I think we could do the same for the strumming directive.

bloodybowlers commented 5 years ago

Any ideas for the strumming directive display ?

Some blocks like this maybe : 

1 & 2 & 3 & 4 &
D - D - U - U - D -

or maybe, simply

D-U-DD-UD