bloodybowlers / UkeGeeks-ng

Ukulele Songbook Website
GNU General Public License v3.0
6 stars 5 forks source link

REQUEST: Modify SongList when Sorted by "TITLE" #81

Open SunflowerGUY opened 4 years ago

SunflowerGUY commented 4 years ago

Hello, I'd like to request a modification when the songbook is sorted by TITLE, to append at the end of each entry, the artists name.

Thank you Adrian.

Louis-coding-UGNG commented 4 years ago

Isn't this already included in the code of song-list-detailed.php? To me this line looks like you only need to swap title and artist (but I might have overlooked something): echo ' <a href="'.$song->Uri.'"'.(Config::openSongInNewTab?' target=_blank':'').'><span class="SongListSong" data-searchable="'.$song->Artist.' - '.$song->Title.'">'.$song->Title.'</span></a>';

SunflowerGUY commented 4 years ago

Hello, I may not have conveyed my request clearly. When sorting by TITLE or CATEGORY, there is currently no Artist Name alongside the song title. This would be most helpful as different songs have been known to share a common Title.

"HELLO" - Adele. "HELLO" - Lionel Ritchie. "BYE BYE LOVE", The Cars "BYE BYE LOVE", The Everly Brothers. "CRAZY", Willie Nelson. * "CRAZY", Gnarls Barkly.

Thanks

Louis-coding-UGNG commented 4 years ago

c'mon, I already pointed you onto the exact file and line - just forgot to add the artist after the title (indeed overlooked that artist was only in the span tag, not in the visible part)

echo ' <a href="'.$song->Uri.'"'.(Config::openSongInNewTab?' target=_blank':'').'><span class="SongListSong" data-searchable="'.$song->Artist.' - '.$song->Title.'">'.$song->Title.', '.$song->Artist.'</span></a>';

make a similar adjustment in line 109 for the category sorted list