bloodycrownD / simple-extension-manager

MIT License
9 stars 2 forks source link

suggestion for adding filter boxs in the bilateral windows #3

Closed BoltLi closed 10 months ago

BoltLi commented 1 year ago

Just as the title says, maybe at last it would look like this:

image

Sorting With alphabet and searcch word are the two functions that I need, and more functions would be welcomed.

bloodycrownD commented 1 year ago

The filtering function has been added, and the plugin can be updated and used now😊. If you find any bugs, please let me know.

BoltLi commented 1 year ago

The filtering function has been added, and the plugin can be updated and used now😊. If you find any bugs, please let me know.

Right now it works well, thanks a lot!✿✿ヽ(°▽°)ノ✿

BoltLi commented 1 year ago

The filtering function has been added, and the plugin can be updated and used now😊. If you find any bugs, please let me know.

Seems there are the some bugs in the search function, as the following picture show that the same extension display more than once. By the way, extensions in the bilateral windows display by alphabet order of the extension's name would be better. image

bloodycrownD commented 1 year ago

The filtering function has been added, and the plugin can be updated and used now😊. If you find any bugs, please let me know.

Seems there are the some bugs in the search function, as the following picture show that the same extension display more than once. By the way, extensions in the bilateral windows display by alphabet order of the extension's name would be better. image

The extension has been updated and the bug has been fixed. If the fix is invalid, please let me know. Now plugins are sorted alphabetically.

BoltLi commented 1 year ago

The extension has been updated and the bug has been fixed. If the fix is invalid, please let me know. Now plugins are sorted alphabetically.

Thanks a lot. Now the plugin work well. But one more thing I think it could improve the using experiencce is to display the plugin alphabetically in the begining, which is the same as vscode plugin display logic.

bloodycrownD commented 1 year ago

The extension has been updated and the bug has been fixed. If the fix is invalid, please let me know. Now plugins are sorted alphabetically.

Thanks a lot. Now the plugin work well. But one more thing I think it could improve the using experiencce is to display the plugin alphabetically in the begining, which is the same as vscode plugin display logic.

I just released the latest version, which has been resolved it.You can now use the latest version😉

BoltLi commented 1 year ago

The extension has been updated and the bug has been fixed. If the fix is invalid, please let me know. Now plugins are sorted alphabetically.

Thanks a lot. Now the plugin work well. But one more thing I think it could improve the using experiencce is to display the plugin alphabetically in the begining, which is the same as vscode plugin display logic.

I just released the latest version, which has been resolved it.You can now use the latest version😉

I have just try, but it seems not work as what I want. I don't know if I explain my mind clearly. What I say before is just show all plugins in the binateral window alphabetically as what vscode do all the time. Regardless of if I hvae search the plugin. image

bloodycrownD commented 1 year ago

image I am experiencing normal functioning here. There might be bugs that I haven't discovered yet. Is there any error message displayed?

BoltLi commented 1 year ago

I am experiencing normal functioning here. There might be bugs that I haven't discovered yet. Is there any error message displayed?

No error, but I have try and find it work well after several search. but at the begining, not work well. Maybe you can try reopen vscode and have a look again.

bloodycrownD commented 10 months ago

Seems there are the some bugs in the search function, as the following picture show that the same extension display more than once.

This is still broken for me. My version is v0.2.2.

Now plugins are sorted alphabetically.

This also doesn't work for me.

Can you run the command code --list-extensions > extensions.list to export the list of extensions? This will help me identify the problem.

BoltLi commented 10 months ago

Can you run the command code --list-extensions > extensions.list to export the list of extensions? This will help me identify the problem.

extensions.log Here it is. It is quite a long list of extensions.

texastoland commented 10 months ago
  1. The issue is plugins are only sorted after adding 1 to the new pack or filtering but not initially.
  2. After filtering there are many items (more every time) left in the menu without images like in the screenshots above.
  3. There's another issue with popular indent-rainbow not having a name and disappearing from the list after sorting alphabetically.
  4. I want to add Simple Extension Manager to a pack but it isn't in the list.
  5. I wish there were an easy way to publish these to VS Marketplace and GitHub.

Otherwise I really love your extension! I deleted my original comment to open these as separate issues with screen recordings 🍿

bloodycrownD commented 10 months ago

I tried again to fix the issue of not being able to sort according to the dictionary. You can try if it is effective.

bloodycrownD commented 10 months ago
  1. The issue is plugins are only sorted after adding 1 to the new pack or filtering but not initially.
  2. After filtering there are many items (more every time) left in the menu without images like in the screenshots above.
  3. There's another issue with popular indent-rainbow not having a name and disappearing from the list after sorting aphabetically.
  4. I want to add Simple Extension Manager to a pack but it isn't in the list.
  5. I wish there were an easy way to publish these to VS Marketplace and GitHub.

Otherwise I really love your extension! I deleted my original comment to open these as separate issues with screen recordings 🍿 Issues 1 and 3 should have been fixed already. For issue 2,I was unable to reproduce the bug , I need more descriptive information and screenshots. For issue 4, I intentionally designed it this way. I don't want the 'Simple Extension Manager' to be managed by other extension packages because it might get disabled along with them if those packages are disabled. For issue 5,in the future, I will try to add this feature. I need to learn how other developers have implemented similar functionalities.

texastoland commented 10 months ago

Issues 1 and 3 should have been fixed already.

Confirmed both fixed 🚀

For issue 2,I was unable to reproduce the bug , I need more descriptive information and screenshots.

I'll open a separate issue with a recording.

For issue 4, I intentionally designed it this way. I don't want the 'Simple Extension Manager' to be managed by other extension packages because it might get disabled along with them if those packages are disabled.

My use case managing all my extensions with Simple Extension Manager. Sometimes I have reason to disable this 1 as well. An alternative might be a confirmation dialog to alert the user of accidentally disabling it?

For issue 5, in the future, I will try to add this feature. I need to learn how other developers have implemented similar functionalities.

My use case is publishing and maintaining packs of top extensions to help other others discover them. Of course I can do it manually. It'd just be nice if there were a GUI to generate and update these packs ✨

  1. I also noticed 1 of your export.json props is pck. Is that a typo?

I believe this issue can be closed!

BoltLi commented 10 months ago

I tried again to fix the issue of not being able to sort according to the dictionary. You can try if it is effective.

Thanks a lot, now it works well.

bloodycrownD commented 10 months ago

For issue 4, I intentionally designed it this way. I don't want the 'Simple Extension Manager' to be managed by other extension packages because it might get disabled along with them if those packages are disabled.

My use case managing all my extensions with Simple Extension Manager. Sometimes I have reason to disable this 1 as well. An alternative might be a confirmation dialog to alert the user of accidentally disabling it?

  1. I also noticed 1 of your export.json props is pck. Is that a typo?

I believe this issue can be closed!

The latest version allows adding "Simple Extension Manager" to the extension package. "pkg” is indeed an attribute of export.json, is there any problem with that?

texastoland commented 10 months ago

The latest version allows adding "Simple Extension Manager" to the extension package.

Yay works I love it 🥰

"pkg” is indeed an attribute of export.json, is there any problem with that?

I don't see that I see this (from my Gist above):

"imgUri": "",
"pck": {
   "name": "tex_recs_🦖_code_intelligence",

It looks like it should be "pack"? Not a problem just letting you know before it's popular!

There's a tiny typo in the edit UI: DiscriptionDescription.

bloodycrownD commented 10 months ago

Thank you for pointing out the spelling mistake, I will fix it.😊