search

bloodyowl / rescript-recoil

Zero-cost bindings to Facebook's Recoil library
MIT License
153 stars 17 forks source link

Update rescript-recoil for rescript 11 #40

Open sprkv5 opened 11 months ago

sprkv5 commented 11 months ago

Kindly pull in a newer version of recoil package and update rescript package dependency to version 11.

bloodyowl commented 10 months ago

PRs are welcome 😊

sprkv5 commented 7 months ago

One of the peer dependencies for this package, is another of your package: rescript-test 6.0.0 Because it defines its peer dependency rescript as "^9.0.0 || ^10.0.0", I'm unable to upgrade rescript version for this package. Should I fork rescript-test as well and update rescript version for it?

ashton commented 7 months ago

I've opened a PR updating everything that is needed, I've just forced the installation of the rescript-test package, it still working fine in the version 11 and I didn't had any issues running the tests. I did this so the update of this project to version 11 wasn't blocked by opening other PR in other repo, but I can do the same for rescript-test afterwards