Open krzychu124 opened 3 years ago
If something go wrong and NetInfo of the node will be null (possible if not all assets are subscribed/enabled) this method will cause infinite loop - game never finish loading a savegame. I've noticed that while testing the user savegame https://github.com/bloodypenguin/Skylines-MetroOverhaulMod/blob/c94dea3be1d4a17ed89faec6b6bfef53235c466c/AssetsUpdater.cs#L430-L451 The instruction from line 447 should be placed outside of if (node.Info != null) check to prevent infinite loop.
NetInfo
null
if (node.Info != null)
Similar situation you can find just a few lines below but the code is correct there. https://github.com/bloodypenguin/Skylines-MetroOverhaulMod/blob/c94dea3be1d4a17ed89faec6b6bfef53235c466c/AssetsUpdater.cs#L452-L470
If something go wrong and
NetInfoof the node will benull(possible if not all assets are subscribed/enabled) this method will cause infinite loop - game never finish loading a savegame. I've noticed that while testing the user savegame https://github.com/bloodypenguin/Skylines-MetroOverhaulMod/blob/c94dea3be1d4a17ed89faec6b6bfef53235c466c/AssetsUpdater.cs#L430-L451 The instruction from line 447 should be placed outside ofif (node.Info != null)check to prevent infinite loop.Similar situation you can find just a few lines below but the code is correct there. https://github.com/bloodypenguin/Skylines-MetroOverhaulMod/blob/c94dea3be1d4a17ed89faec6b6bfef53235c466c/AssetsUpdater.cs#L452-L470