search

bloom-housing / Bloom-Doorway

Issue tracking for Doorway
0 stars 0 forks source link

Align Button / ButtonGroup #30

Open emilyjablonski opened 1 year ago

emilyjablonski commented 1 year ago

DUIC has a local version of Button and ButtonGroup.

There are quite a few changes here especially to ButtonGroup in order for a ButtonGroup to be able to support the new behavior we see on the Doorway home page in the unit type selection where there is one button at a time active with the button group that can be selected. There is a lot of added business logic to the components that shouldn't be in the component.

We either need (1) a custom component that only exists in Doorway that is a new form component that handles a selectable button group, or if we think it's generalizable we could add it to UIC - since we are working on overhauling forms, I'd recommend just a local Doorway component, but still getting them aligned on our Button elsewhere.

Their changes in the SCSS file for Button can for the most part be handled with existing overrides. We would need a small PR to UIC to add a few new overrides that aren’t possible now.

slowbot commented 1 year ago

@emilyjablonski Do you think it makes sense to migrate the "selectable button group" to be a style of checkbox or radio depending on the selection of one or more options?

emilyjablonski commented 1 year ago

From an accessibility perspective, a stylized radio would be perfect here

emilyjablonski commented 1 year ago

Note: We're working on Seeds button uptake in core so we should put this on hold until that has been released in Doorway in terms of adding overriddes to support Doorway styles. We'll still to figure out a path forward with the ButtonGroup. Given the timeline on forms I'd recommend a local component in Doorway public.