bloom-housing / bloom

component-based web framework for affordable housing management
Apache License 2.0
33 stars 24 forks source link

UISeeds - Menu Component #3335

Closed emilyjablonski closed 6 months ago

emilyjablonski commented 1 year ago

Description

Transfer the SideNav component from UIC to UISeeds.

Links

Eng Audit [Zero height Docs]((https://www.notion.so/exygy/Side-Nav-8adbd9e86bc34400aaf526f08245cd9f?pvs=4)

Additional Details

Acceptance Criteria

Figma

QA review/instructions

slowbot commented 1 year ago

@emilyjablonski @jaredcwhite Design spec and breakpoint docs https://www.figma.com/file/SsYt5YsgbmOPbwr5Qk2RKB/bloom-core-library?node-id=3316%3A10885&t=iAKnk6RouT6G9JBC-1

zeroheight docs https://exygy.zeroheight.com/styleguide/s/100882/p/7110b9-menu/b/93a6d7

emilyjablonski commented 1 year ago
slowbot commented 1 year ago
slowbot commented 1 year ago

@jaredcwhite @emilyjablonski Updated docs to reflect our conversation.

https://exygy.zeroheight.com/styleguide/s/100882/p/7110b9-menu/b/091080 https://www.figma.com/file/SsYt5YsgbmOPbwr5Qk2RKB/bloom-core-library?node-id=3754%3A21315&t=aPETx8GXyyjhWHvz-1

emilyjablonski commented 1 year ago

Thank you!

A remaining question I have about the last row is why the vertical version on smaller screens defaults to menu, vs just letting consumers decide if they want menu. I'm not sure having that breakpoint is the best path.

I'm also not seeing the notes from your 4th bullet point of documenting horizontal display of nested items, lmk if I'm missing that somewhere!

@slowbot

slowbot commented 1 year ago

https://github.com/bloom-housing/ui-seeds/issues/29

slowbot commented 1 year ago

@emilyjablonski @jaredcwhite added story details and removed blocked tag

jaredcwhite commented 6 months ago

Closed in favor of an updated issue in the Seeds repo: https://github.com/bloom-housing/ui-seeds/issues/77