fix: add the ability to disconnect community types

ludtkemorgan commented 3 months ago

This PR addresses #4140

[x] Addresses the issue in full
[ ] Addresses only certain aspects of the issue

Description

When a reserved community type already exists on a listing and should be removed it was not properly being removed because it needs to be "disconnected" rather than just set to undefined

How Can This Be Tested/Reviewed?

Add a community type to a listing and save the listing. Then re-edit the listing and remove the reserved community type. The community type should no longer be on the listing

Author Checklist:

[ ] Added QA notes to the issue with applicable URLs
[x] Reviewed in a desktop view
[x] Reviewed in a mobile view
[x] Reviewed considering accessibility
[x] Added tests covering the changes
[ ] Made corresponding changes to the documentation
[ ] Ran yarn generate:client and/or created a migration when required

Review Process:

Read and understand the issue
Ensure the author has added QA notes
Review the code itself from a style point of view
Pull the changes down locally and test that the acceptance criteria is met
Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

netlify[bot] commented 3 months ago

Deploy Preview for partners-bloom-dev ready!

Name	Link
Latest commit	fd0803f732417179d8804fc07ef4f9f3d844cbb4
Latest deploy log	https://app.netlify.com/sites/partners-bloom-dev/deploys/6678a5850235b900089b80d7
Deploy Preview	https://deploy-preview-4153--partners-bloom-dev.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 3 months ago

Deploy Preview for bloom-exygy-dev ready!

Name	Link
Latest commit	fd0803f732417179d8804fc07ef4f9f3d844cbb4
Latest deploy log	https://app.netlify.com/sites/bloom-exygy-dev/deploys/6678a58587ec520008a044a0
Deploy Preview	https://deploy-preview-4153--bloom-exygy-dev.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

bloom-housing / bloom