fix: filter ami charts by jurisdition

ludtkemorgan commented 4 months ago

This PR addresses #4174

[x] Addresses the issue in full
[ ] Addresses only certain aspects of the issue

Description

When making the backend call to get AMI charts on the partner site the jurisdiction id was not getting set. This was due to a change in Prisma where the jurisdiction field was changed to "jurisdictions" so the watch function was not looking for the correct field

How Can This Be Tested/Reviewed?

Note: a new ami chart was added to the stage seeded data tied to the second jurisdiction so I'd recommend a reseed before testing

Log into the partner site as an admin
Add a new listing.
Go to add a new unit within the listing and make sure that all AMI charts are accessible in the dropdown
Set a jurisdiction to the listing and then try to add a unit. Only the AMI charts for that jurisdiction are accessible

Author Checklist:

[x] Added QA notes to the issue with applicable URLs
[x] Reviewed in a desktop view
[x] Reviewed in a mobile view
[ ] Reviewed considering accessibility
[ ] Added tests covering the changes
[ ] Made corresponding changes to the documentation
[ ] Ran yarn generate:client and/or created a migration when required

Review Process:

Read and understand the issue
Ensure the author has added QA notes
Review the code itself from a style point of view
Pull the changes down locally and test that the acceptance criteria is met
Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

netlify[bot] commented 4 months ago

Deploy Preview for partners-bloom-dev ready!

Name	Link
Latest commit	9e151b885c6c8f6539593ae5bf3dc7b6f7717dda
Latest deploy log	https://app.netlify.com/sites/partners-bloom-dev/deploys/668570fb4c6db40008d83d3a
Deploy Preview	https://deploy-preview-4177--partners-bloom-dev.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 4 months ago

Deploy Preview for bloom-exygy-dev ready!

Name	Link
Latest commit	9e151b885c6c8f6539593ae5bf3dc7b6f7717dda
Latest deploy log	https://app.netlify.com/sites/bloom-exygy-dev/deploys/668570fbea211900082e1f56
Deploy Preview	https://deploy-preview-4177--bloom-exygy-dev.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ludtkemorgan commented 4 months ago

Looks good! While we have this front of mind, maybe we want to consider the case where a unit is created using an AMI from another jurisdiction and then the jurisdiction is set/changed. Just some food for though.

That's a good point! There are a decent amount of units in HBA staging that have AMI charts that aren't associated to the correct jurisdiction. I don't know how common in prod it is, but I think it's something we probably should prevent. I'll create a ticket.

bloom-housing / bloom