feat: new applications release modal

emilyjablonski commented 3 months ago

This PR addresses #4189

[x] Addresses the issue in full

Description

You now cannot release a lottery to partners if you have added or updated application data since the last run.

How Can This Be Tested/Reviewed?

As an admin on a closed listing with a lottery, run the lottery. Add or update an application on that listing, and then try to release the lottery. You should get this modal, though with just one OK button and the additional text about updating.

Author Checklist:

[x] Added QA notes to the issue with applicable URLs
[x] Reviewed in a desktop view
[x] Reviewed in a mobile view
[x] Reviewed considering accessibility
[ ] Added tests covering the changes
[ ] Made corresponding changes to the documentation
[ ] Ran yarn generate:client and/or created a migration when required

Review Process:

Read and understand the issue
Ensure the author has added QA notes
Review the code itself from a style point of view
Pull the changes down locally and test that the acceptance criteria is met
Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

netlify[bot] commented 3 months ago

Deploy Preview for partners-bloom-dev ready!

Name	Link
Latest commit	9bb7a8ffc69616de377fb6f1f184c5f3baa2d4c9
Latest deploy log	https://app.netlify.com/sites/partners-bloom-dev/deploys/669ef276d13dec0008177e8a
Deploy Preview	https://deploy-preview-4217--partners-bloom-dev.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 3 months ago

Deploy Preview for bloom-exygy-dev ready!

Name	Link
Latest commit	9bb7a8ffc69616de377fb6f1f184c5f3baa2d4c9
Latest deploy log	https://app.netlify.com/sites/bloom-exygy-dev/deploys/669ef276582773000814e541
Deploy Preview	https://deploy-preview-4217--bloom-exygy-dev.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mcgarrye commented 3 months ago

Is there any concern about the scenario where the lottery has already been released or publish and an admin still adds a new application?

emilyjablonski commented 3 months ago

@mcgarrye We do have a modal that pops up if you try and add an application after a lottery has been run, but I can ask design about that!

bloom-housing / bloom