feat: spreadsheetification of lottery export

YazeedLoonat commented 3 months ago

This PR addresses #4056

[x] Addresses the issue in full

Description

This converts the raw rank application lottery export from a csv expor to a spreadsheet export

How Can This Be Tested/Reviewed?

Unit tests were added but you can test this on the front end by:

logging into the partner site
close a listing
run the lottery for that listing
export the results

Author Checklist:

[ ] Added QA notes to the issue with applicable URLs
[x] Reviewed in a desktop view
[ ] Reviewed in a mobile view
[ ] Reviewed considering accessibility
[x] Added tests covering the changes
[ ] Made corresponding changes to the documentation
[x] Ran yarn generate:client and/or created a migration when required

Review Process:

Read and understand the issue
Ensure the author has added QA notes
Review the code itself from a style point of view
Pull the changes down locally and test that the acceptance criteria is met
Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

netlify[bot] commented 3 months ago

Deploy Preview for partners-bloom-dev ready!

Name	Link
Latest commit	0bd330d5b4d74ffec40211b9235b7babe1897352
Latest deploy log	https://app.netlify.com/sites/partners-bloom-dev/deploys/66abfa14d1fddb000823a0a5
Deploy Preview	https://deploy-preview-4228--partners-bloom-dev.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 3 months ago

Deploy Preview for bloom-exygy-dev ready!

Name	Link
Latest commit	0bd330d5b4d74ffec40211b9235b7babe1897352
Latest deploy log	https://app.netlify.com/sites/bloom-exygy-dev/deploys/66abfa1481aaf600083b3881
Deploy Preview	https://deploy-preview-4228--bloom-exygy-dev.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ColinBuyck commented 3 months ago

Talked offline about the adding application weirdness with @YazeedLoonat and the steps I took were to

run lottery
get export
add application
try to get export again (500 response)

I am assuming that blocking this flow is part of upcoming FE work but I suggested that the error should be better handled at some point

YazeedLoonat commented 3 months ago

@ColinBuyck from convo in the slack channel it seems like this wasn't really accounted for but with the toasts being readded when it errors it does let the UI know. Lemme know if thats enough for now

@ludtkemorgan left a few comments back based on your comments, but for your top level comment there is a ticket to switch the application export to be a spreadsheet export as well so I think it'd be work to switch the csv export up when it seems likely it'll go away so leaving that in place here.

Although maybe in that ticket we can do some investigation

ludtkemorgan commented 3 months ago

Looks good. I'm putting this comment down here so we hopefully don't forget, but there are a few changes in the columns outputted on application export in Doorway. And since this is a big refactor when we pull it over to Doorway we'll need to remember to add those new fields to both application and lottery exports

bloom-housing / bloom