bloom-housing / bloom

component-based web framework for affordable housing management
Apache License 2.0
34 stars 24 forks source link

feat: adding preference sheets to lottery export #4233

Closed YazeedLoonat closed 1 month ago

YazeedLoonat commented 1 month ago

This PR addresses #4056

Description

This adds the preference sheets to the lottery export as well as a few other things:

How Can This Be Tested/Reviewed?

you should notice individual sheets for each preference as well as the original raw sheet

Author Checklist:

Review Process:

netlify[bot] commented 1 month ago

Deploy Preview for partners-bloom-dev ready!

Name Link
Latest commit 62ec0127ad03067d5518f9444a55bf1bffa0cf2c
Latest deploy log https://app.netlify.com/sites/partners-bloom-dev/deploys/66ba73fc2c5bdc00086732a4
Deploy Preview https://deploy-preview-4233--partners-bloom-dev.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 1 month ago

Deploy Preview for bloom-exygy-dev ready!

Name Link
Latest commit 62ec0127ad03067d5518f9444a55bf1bffa0cf2c
Latest deploy log https://app.netlify.com/sites/bloom-exygy-dev/deploys/66ba73fce7c72d0008899c15
Deploy Preview https://deploy-preview-4233--bloom-exygy-dev.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ludtkemorgan commented 1 month ago

@mcgarrye the bug with all showing the same rank has been fixed. There was a = instead of ===. I'll also add some tests around that

emilyjablonski commented 1 month ago

The sample export has a slightly different column order with the raw rank coming first

ludtkemorgan commented 1 month ago

@mcgarrye nice catch. I have fixed the columns to have the right data