feat: require lottery date time fields

mcgarrye commented 1 month ago

This PR addresses #(4212)

[x] Addresses the issue in full
[ ] Addresses only certain aspects of the issue

Description

When a listing has lottery selected and has opted in to our lottery system, the lottery start date, start time and end time fields should be required. When any of the 3 fields are not filled out, an error will appear on save and all 3 fields will be highlighted.

How Can This Be Tested/Reviewed?

Create or edit a listing in the partners portal. Save with First Come First Serve selected. No errors should appear. Edit and save with Lottery selected and No selected for optin. No errors should appear. Edit and select Yes for optin. Do not fill out start date, start time and end time fields. Error should appear and fields should be highlighted. Cancel edit. Edit and select Yes for optin. Fill out some but not all of the fields. Error should appear and fields should be highlighted. Cancel edit. Edit and select Yes for optin. Fill out all of the fields. Save and no errors should appear. Edit and remove one of the lottery date fields. Error should appear and fields should be highlighted. Cancel edit.

Author Checklist:

[x] Added QA notes to the issue with applicable URLs
[x] Reviewed in a desktop view
[ ] Reviewed in a mobile view
[ ] Reviewed considering accessibility
[x] Added tests covering the changes
[ ] Made corresponding changes to the documentation
[ ] Ran yarn generate:client and/or created a migration when required

Review Process:

Read and understand the issue
Ensure the author has added QA notes
Review the code itself from a style point of view
Pull the changes down locally and test that the acceptance criteria is met
Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

netlify[bot] commented 1 month ago

Deploy Preview for partners-bloom-dev ready!

Name	Link
Latest commit	3986fc117208f0effb5d8d0e1efc92b137af0865
Latest deploy log	https://app.netlify.com/sites/partners-bloom-dev/deploys/66bbb0012c5bdc0008600b44
Deploy Preview	https://deploy-preview-4250--partners-bloom-dev.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 1 month ago

Deploy Preview for bloom-exygy-dev ready!

Name	Link
Latest commit	12c7407937cfb6850a7fdb99994a6766fa284c8d
Latest deploy log	https://app.netlify.com/sites/bloom-exygy-dev/deploys/66bb8d26b94a0000089ac721
Deploy Preview	https://deploy-preview-4250--bloom-exygy-dev.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 1 month ago

Deploy Preview for bloom-exygy-dev ready!

Name	Link
Latest commit	3986fc117208f0effb5d8d0e1efc92b137af0865
Latest deploy log	https://app.netlify.com/sites/bloom-exygy-dev/deploys/66bbb001cde1bf000811cb8d
Deploy Preview	https://deploy-preview-4250--bloom-exygy-dev.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

bloom-housing / bloom