feat: feature flag and new endpoint

ColinBuyck commented 1 month ago

This PR addresses #4248

[x] Addresses the issue in full
[ ] Addresses only certain aspects of the issue

Description

This PR adds feature flagging to hide or show the side nav and creates a custom call to reduce the load time for accounts with numerous applications.

Add SHOW_LOTTERY=TRUE to the public side

One note that you will see ApplicationsIndexEnum and ApplicationsFilterEnum are very similar but based on the current implementation requiring tabs, offline convo landed on using both would be best to maintain strong typing on the BE and easy tab selection based on index + better readability on the FE.

How Can This Be Tested/Reviewed?

This can be tested by signing into an account, applying to more than one listing, and seeing in the network tab that only one call is being made no matter how many listings there are. Additionally, you can rerun the application with the new feature flag set to false, and you will no longer see the Lottery run tab but everything else should work as expected.

Author Checklist:

[x] Added QA notes to the issue with applicable URLs
[ ] Reviewed in a desktop view
[ ] Reviewed in a mobile view
[ ] Reviewed considering accessibility
[ ] Added tests covering the changes
[ ] Made corresponding changes to the documentation
[ ] Ran yarn generate:client and/or created a migration when required

Review Process:

Read and understand the issue
Ensure the author has added QA notes
Review the code itself from a style point of view
Pull the changes down locally and test that the acceptance criteria is met
Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

netlify[bot] commented 1 month ago

Deploy Preview for partners-bloom-dev ready!

Name	Link
Latest commit	96592dd3a926217090c8e6c294fc89707a88c4ba
Latest deploy log	https://app.netlify.com/sites/partners-bloom-dev/deploys/66c51c26b4ffcc00084c269c
Deploy Preview	https://deploy-preview-4252--partners-bloom-dev.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 1 month ago

Deploy Preview for bloom-exygy-dev ready!

Name	Link
Latest commit	96592dd3a926217090c8e6c294fc89707a88c4ba
Latest deploy log	https://app.netlify.com/sites/bloom-exygy-dev/deploys/66c51c262946500008c2481b
Deploy Preview	https://deploy-preview-4252--bloom-exygy-dev.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

bloom-housing / bloom