Closed jaredcwhite closed 3 weeks ago
Name | Link |
---|---|
Latest commit | df087e4d61053804c0bc25a5739a92514408bb90 |
Latest deploy log | https://app.netlify.com/sites/bloom-exygy-dev/deploys/66bee6c5017fe90008229429 |
Deploy Preview | https://deploy-preview-4256--bloom-exygy-dev.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Name | Link |
---|---|
Latest commit | 7c6e6ccde88ca72e6083bd8658de359341fdc6ab |
Latest deploy log | https://app.netlify.com/sites/partners-bloom-dev/deploys/66ccee2b74718e00087e1fc3 |
Deploy Preview | https://deploy-preview-4256--partners-bloom-dev.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Name | Link |
---|---|
Latest commit | 7c6e6ccde88ca72e6083bd8658de359341fdc6ab |
Latest deploy log | https://app.netlify.com/sites/bloom-exygy-dev/deploys/66ccee2b1b1b790008b4c5a9 |
Deploy Preview | https://deploy-preview-4256--bloom-exygy-dev.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
If I update the listing's name with save, the listing header doesn't change and they then mismatch
If I get an error, fix it, and then save, I end up in a state where both the error alert and the success toast are there. I wonder if we can dismiss the error toast on save but that might be funky.
I feel like the behavior here is preferred, but if a listing is already live and I click save, I get this modal and then get redirected to the edit page instead of this new save flow - but I also think that makes sense, I just don't see it covered in the AC.
Thanks for the review @emilyjablonski! Working through the various issues/questions now.
Just pushed up fixes for the listing name in header not changing and the error alert not disappearing.
I feel like the behavior here is preferred, but if a listing is already live and I click save, I get this modal and then get redirected to the edit page instead of this new save flow - but I also think that makes sense, I just don't see it covered in the AC.
I think the AC was unspecified with regard to confirmation modals. I think this makes sense too, but we could ask for design QA to verify.
This PR addresses #3654
Description
This PR changes the "Save & Exit" button so it just reads "Save", and clicking it will save the listing and remain in the edit state. In addition, the "Cancel" button has been renamed "Exit" and it displays a prompt to the user to either save or discard changes.
How Can This Be Tested/Reviewed?
Try saving or exiting listings in various stages (new, unpublished, published, etc.) and verify the behavior matches the AC/Figma.
Author Checklist:
yarn generate:client
and/or created a migration when requiredReview Process: