fix: fetch ami chart with the proper id

ludtkemorgan commented 1 month ago

Description

While bug bashing a bug was noticed in firefox during the listing creation flow on adding units. Specifically when selecting an AMI chart the data isn't getting populated.

I am unsure why it happens to exist in Firefox but the issue is because of the order of values getting set. In Chrome and other browsers during the onChange event the value for amiChartID is set first whereas in firefox the value is not set by the time we get to the place where we need to know the id. This is resolved by getting the value directly from the select onChange rather than relying on the value we get from the useWatch function.

How Can This Be Tested/Reviewed?

This bug only exists in firefox so it is recommended to test there as well as other browsers.

On the partner page add a new listing and add a unit
Select an ami chart for this unit and make sure that the percentage select field is populated.
Select a percentage and make sure that the ami chart data table is populated
Switch to another ami chart and verify that it changes.

Author Checklist:

[ ] Added QA notes to the issue with applicable URLs
[x] Reviewed in a desktop view
[x] Reviewed in a mobile view
[x] Reviewed considering accessibility
[n/a] Added tests covering the changes
[ ] Made corresponding changes to the documentation
[ ] Ran yarn generate:client and/or created a migration when required

Review Process:

Read and understand the issue
Ensure the author has added QA notes
Review the code itself from a style point of view
Pull the changes down locally and test that the acceptance criteria is met
Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

netlify[bot] commented 1 month ago

Deploy Preview for partners-bloom-dev ready!

Name	Link
Latest commit	4aa1ce99f5666897c9fa012f94527a0f522a19ef
Latest deploy log	https://app.netlify.com/sites/partners-bloom-dev/deploys/66c514b95709de0008dda2d5
Deploy Preview	https://deploy-preview-4259--partners-bloom-dev.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 1 month ago

Deploy Preview for bloom-exygy-dev ready!

Name	Link
Latest commit	4aa1ce99f5666897c9fa012f94527a0f522a19ef
Latest deploy log	https://app.netlify.com/sites/bloom-exygy-dev/deploys/66c514b92c67110008a5e9ec
Deploy Preview	https://deploy-preview-4259--bloom-exygy-dev.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

bloom-housing / bloom