fix: update zip length requirement and error messaging

ColinBuyck commented 2 months ago

This PR addresses #4260

[x] Addresses the issue in full
[ ] Addresses only certain aspects of the issue

Description

This PR updates the length validation on Zip Code fields to be 10 which matches the verify endpoint length. This also updates the error message be take in the length rather than hardcoding 64 characters.

How Can This Be Tested/Reviewed?

This can be tested by attempting to fill out the application and zip code field with more than 10 characters and seeing the appropriate error message.

Author Checklist:

[ ] Added QA notes to the issue with applicable URLs
[x] Reviewed in a desktop view
[ ] Reviewed in a mobile view
[ ] Reviewed considering accessibility
[ ] Added tests covering the changes
[ ] Made corresponding changes to the documentation
[ ] Ran yarn generate:client and/or created a migration when required

Review Process:

Read and understand the issue
Ensure the author has added QA notes
Review the code itself from a style point of view
Pull the changes down locally and test that the acceptance criteria is met
Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

netlify[bot] commented 2 months ago

Deploy Preview for partners-bloom-dev ready!

Name	Link
Latest commit	e9701cdf9c6bdc0ef2193af9245bdabd7cad5cb6
Latest deploy log	https://app.netlify.com/sites/partners-bloom-dev/deploys/66c4fe1628689c0008bff0aa
Deploy Preview	https://deploy-preview-4261--partners-bloom-dev.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 2 months ago

Deploy Preview for bloom-exygy-dev ready!

Name	Link
Latest commit	e9701cdf9c6bdc0ef2193af9245bdabd7cad5cb6
Latest deploy log	https://app.netlify.com/sites/bloom-exygy-dev/deploys/66c4fe16237417000814e98d
Deploy Preview	https://deploy-preview-4261--bloom-exygy-dev.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

bloom-housing / bloom