fix: lottery translations script bug

emilyjablonski commented 3 weeks ago

This PR addresses #4272

[x] Addresses the issue in full

Description

This fixes a bug that was causing the lottery translations script to fail. We are using the default translations, i.e. not tied to a jurisdictional ID, and not all jurisdictions had existing default translations across all languages.

How Can This Be Tested/Reviewed?

Start the app, and via swagger log-in and run the new script. Ensure it succeeds and that the translations are in the database.

If you want to test the user flow, you can also submit an application in a foreign language while signed in to one of your own emails, and then run and publish that lottery to get the email (screenshot below).

Author Checklist:

[x] Added QA notes to the issue with applicable URLs
[ ] Reviewed in a desktop view
[ ] Reviewed in a mobile view
[ ] Reviewed considering accessibility
[x] Added tests covering the changes
[ ] Made corresponding changes to the documentation
[x] Ran yarn generate:client and/or created a migration when required

Review Process:

Read and understand the issue
Ensure the author has added QA notes
Review the code itself from a style point of view
Pull the changes down locally and test that the acceptance criteria is met
Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

netlify[bot] commented 3 weeks ago

Deploy Preview for partners-bloom-dev ready!

Name	Link
Latest commit	b642b5cf89d4a50cefdc0ca3b6ae76dfd9c95028
Latest deploy log	https://app.netlify.com/sites/partners-bloom-dev/deploys/66cf7f10d0218200078f4d05
Deploy Preview	https://deploy-preview-4283--partners-bloom-dev.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 3 weeks ago

Deploy Preview for bloom-exygy-dev ready!

Name	Link
Latest commit	b642b5cf89d4a50cefdc0ca3b6ae76dfd9c95028
Latest deploy log	https://app.netlify.com/sites/bloom-exygy-dev/deploys/66cf7f105f7add0009916fa5
Deploy Preview	https://deploy-preview-4283--bloom-exygy-dev.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

emilyjablonski commented 2 weeks ago

@ColinBuyck Great q for what to do for applications marked as a duplicate - been poking prod/design about how to handle that on the public site as well for applications that won't be given lottery results. I'll ask about this specifically and get back to you!

bloom-housing / bloom