feat: lottery public list view

ColinBuyck commented 2 months ago

This PR addresses #4053

[x] Addresses the issue in full
[ ] Addresses only certain aspects of the issue

Description

This PR adds the final touches to the applications lottery view of the public side. This mainly includes custom tags and dates. It also includes some string twekas (@eajensenwa approved the "View application" vs "View your application" tweak)

How Can This Be Tested/Reviewed?

This can be tested by signing into the public site and applying to a few different listings. Then, update the listings to show as open without a due date, open with a due date, closed without a lottery date, closed with a lottery date, and lottery ran.

Additionally ensure all tests have passed below.

Author Checklist:

[x] Added QA notes to the issue with applicable URLs
[x] Reviewed in a desktop view
[ ] Reviewed in a mobile view
[ ] Reviewed considering accessibility
[x] Added tests covering the changes
[ ] Made corresponding changes to the documentation
[ ] Ran yarn generate:client and/or created a migration when required

Review Process:

Read and understand the issue
Ensure the author has added QA notes
Review the code itself from a style point of view
Pull the changes down locally and test that the acceptance criteria is met
Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

netlify[bot] commented 2 months ago

Deploy Preview for partners-bloom-dev ready!

Name	Link
Latest commit	0ba5d74c694affa80d181237fa7d3ca5946e9749
Latest deploy log	https://app.netlify.com/sites/partners-bloom-dev/deploys/66d9eae70d8aab0008e4cff5
Deploy Preview	https://deploy-preview-4286--partners-bloom-dev.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 2 months ago

Deploy Preview for bloom-exygy-dev ready!

Name	Link
Latest commit	0ba5d74c694affa80d181237fa7d3ca5946e9749
Latest deploy log	https://app.netlify.com/sites/bloom-exygy-dev/deploys/66d9eae7b3da260008888ba9
Deploy Preview	https://deploy-preview-4286--bloom-exygy-dev.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

emilyjablonski commented 2 months ago

The design has the text Status: in front of the status pills which is missing here. TBH I prefer the behavior on this PR, the text seems redundant, but just wanted to check in if you had passed that by Em.

ColinBuyck commented 2 months ago

Thanks for the reviews! Responded to each thread and got confirmation from design that excluding the status text works @emilyjablonski. Will merge once new tests pass.

bloom-housing / bloom