fix: correctly bind publish job

mcgarrye commented 1 week ago

This PR addresses #(insert-number-here)

[x] Addresses the issue in full
[ ] Addresses only certain aspects of the issue

Description

Lottery auto publish cron job was incorrectly binded and thus not running. Now correctly binded.

How Can This Be Tested/Reviewed?

Set the LOTTERY_PUBLISH_PROCESSING_CRON_STRING env var to something in the next few minutes and run the api. Verify "WARN autoPublishLotteryResults job running" and "WARN Changed the status of ${number} lotteries" both appear in the console.

Author Checklist:

[x] Added QA notes to the issue with applicable URLs
[x] Reviewed in a desktop view
[ ] Reviewed in a mobile view
[ ] Reviewed considering accessibility
[ ] Added tests covering the changes
[ ] Made corresponding changes to the documentation
[ ] Ran yarn generate:client and/or created a migration when required

Review Process:

Read and understand the issue
Ensure the author has added QA notes
Review the code itself from a style point of view
Pull the changes down locally and test that the acceptance criteria is met
Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

netlify[bot] commented 1 week ago

Deploy Preview for bloom-exygy-dev ready!

Name	Link
Latest commit	7aa57d13c18ecb3b22927b8656ca4d533bb49f9e
Latest deploy log	https://app.netlify.com/sites/bloom-exygy-dev/deploys/66e0606902f3820008925280
Deploy Preview	https://deploy-preview-4313--bloom-exygy-dev.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 1 week ago

Deploy Preview for partners-bloom-dev ready!

Name	Link
Latest commit	7aa57d13c18ecb3b22927b8656ca4d533bb49f9e
Latest deploy log	https://app.netlify.com/sites/partners-bloom-dev/deploys/66e0606999f4630008f682ed
Deploy Preview	https://deploy-preview-4313--partners-bloom-dev.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

emilyjablonski commented 1 week ago

Makes sense! LGTM after green tests

bloom-housing / bloom