bloom-housing / bloom

Bloom is Exygy’s affordable housing platform. Bloom's goal is to be a single entry point for affordable housing seekers and a hub for application and listing management for developers.
https://bloomhousing.com
Apache License 2.0
33 stars 25 forks source link

fix: remove dwy copy #4339

Closed ColinBuyck closed 1 month ago

ColinBuyck commented 1 month ago

This PR addresses #4338

Description

This change removes dwy specific lottery copy in the partner's lottery export terms (as approved by product). I left the Terms of Use string translations since Sarah said we would be using it soon for HBA's implementation.

How Can This Be Tested/Reviewed?

Add a partner user to a lottery listing and attempt to export the lottery. You should see a reduced modal.

Author Checklist:

Review Process:

netlify[bot] commented 1 month ago

Deploy Preview for bloom-exygy-dev ready!

Name Link
Latest commit 85b997e1cbb1611d5994457013f40daa1eeb2848
Latest deploy log https://app.netlify.com/sites/bloom-exygy-dev/deploys/66ea07eab1871d0008fce5d4
Deploy Preview https://deploy-preview-4339--bloom-exygy-dev.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 1 month ago

Deploy Preview for partners-bloom-dev ready!

Name Link
Latest commit 85b997e1cbb1611d5994457013f40daa1eeb2848
Latest deploy log https://app.netlify.com/sites/partners-bloom-dev/deploys/66ea07ea6e04a90008b899bb
Deploy Preview https://deploy-preview-4339--partners-bloom-dev.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

emilyjablonski commented 1 month ago

To me the ticket reads as adjusting the terms to make them more general, as opposed to removing them - esp since we have a ticket to make the terms required by adding a checkbox, I'm wondering if we add the general terms into core?

ColinBuyck commented 1 month ago

@emilyjablonski I should've also included this context but I talked to Sarah about the checkbox work and that is meant to be only done in Doorway. I verified with her that this is the desired core experience (and then wrote the ticket after 😔 ). Does that help clarify things?