fix: only show lottery button if app has results

emilyjablonski commented 2 days ago

This PR addresses #4303

[x] Addresses the issue in full
[ ] Addresses only certain aspects of the issue

Description

Only show View lottery results button if we actually have results - which will by default filter out duplicates that don't have results if they were not included in the lottery.

How Can This Be Tested/Reviewed?

Ensure the button only shows on a published lottery listing if the application has results (which it won't for a duplicate you confirm and exclude from the lottery).

Author Checklist:

[x] Added QA notes to the issue with applicable URLs
[x] Reviewed in a desktop view
[x] Reviewed in a mobile view
[x] Reviewed considering accessibility
[ ] Added tests covering the changes
[ ] Made corresponding changes to the documentation
[ ] Ran yarn generate:client and/or created a migration when required

Review Process:

Read and understand the issue
Ensure the author has added QA notes
Review the code itself from a style point of view
Pull the changes down locally and test that the acceptance criteria is met
Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

netlify[bot] commented 2 days ago

Deploy Preview for partners-bloom-dev ready!

Name	Link
Latest commit	a25a5c8d75a33bf1de06525a40e3d40e80c6f08b
Latest deploy log	https://app.netlify.com/sites/partners-bloom-dev/deploys/66eb6b8595343000087f331d
Deploy Preview	https://deploy-preview-4345--partners-bloom-dev.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 2 days ago

Deploy Preview for bloom-exygy-dev ready!

Name	Link
Latest commit	a25a5c8d75a33bf1de06525a40e3d40e80c6f08b
Latest deploy log	https://app.netlify.com/sites/bloom-exygy-dev/deploys/66eb6b8556279f00087d13cd
Deploy Preview	https://deploy-preview-4345--bloom-exygy-dev.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

bloom-housing / bloom