fix: dont send lottery emails to duplicate applications

emilyjablonski commented 2 days ago

This PR addresses #4312

[x] Addresses the issue in full
[ ] Addresses only certain aspects of the issue

Description

A change to not send lottery published emails to applications that have been marked as a duplicate. Also changes the email we are sending the lottery results to to the email associated with the account that applied, as opposed to the email field on the application, since the account email has been verified. Chatted with Sarah about what this means for HBA and lottery without them having mandated accounts - before we would release lottery in HBA we may have to consider turning mandated accounts on for the public side experience of receiving results - and that we should still use the account email here so folks know when they receive an email they need to login with that email to see the results.

How Can This Be Tested/Reviewed?

Submit two applications while logged in under different email accounts, but use same name / dob, as a partner mark one as a duplicate, and after publishing the lottery ensure only the valid email received a notification.

Author Checklist:

[x] Added QA notes to the issue with applicable URLs
[x] Reviewed in a desktop view
[x] Reviewed in a mobile view
[x] Reviewed considering accessibility
[ ] Added tests covering the changes
[ ] Made corresponding changes to the documentation
[ ] Ran yarn generate:client and/or created a migration when required

Review Process:

Read and understand the issue
Ensure the author has added QA notes
Review the code itself from a style point of view
Pull the changes down locally and test that the acceptance criteria is met
Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

netlify[bot] commented 2 days ago

Deploy Preview for partners-bloom-dev ready!

Name	Link
Latest commit	c5d50235e41c2b4429ac153a9347cc9f40fa8ddc
Latest deploy log	https://app.netlify.com/sites/partners-bloom-dev/deploys/66eca213a642520009161ab0
Deploy Preview	https://deploy-preview-4346--partners-bloom-dev.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 2 days ago

Deploy Preview for bloom-exygy-dev ready!

Name	Link
Latest commit	c5d50235e41c2b4429ac153a9347cc9f40fa8ddc
Latest deploy log	https://app.netlify.com/sites/bloom-exygy-dev/deploys/66eca213b94bbc000808a08a
Deploy Preview	https://deploy-preview-4346--bloom-exygy-dev.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

bloom-housing / bloom