bloom-housing / ui-components

0 stars 2 forks source link

fix: remove z-index #121

Closed chadbrokaw-exygy closed 1 year ago

chadbrokaw-exygy commented 1 year ago

Pull Request Template

issue

120

Description

In DAHLIA the Listing tag is appearing on top of the slide out menu. We fixed this a bit ago by removing the Z-Index requirement, but it looks like that was added back. The agreed upon resolution is to remove the Z-Index field.

Before:

Screenshot 2023-08-24 at 8 55 41 AM

After:

Screenshot 2023-08-24 at 8 53 47 AM

How Can This Be Tested/Reviewed?

Provide instructions so we can review.

  1. On DAHLIA, go to /listings/a0W0P00000GwGl3UAF and open the inspector.
  2. Turn on the mobile emulator
  3. Open the slide-out menu by tapping the hamburger icon in the top right
  4. The tag will be underneath the menu

On another website, open a listing that uses tags and follow steps 2 through 4.

Checklist:

Reviewer Notes:

Steps to review a PR:

On merge, squash commits.

netlify[bot] commented 1 year ago

Deploy Preview for storybook-bloom-dev ready!

Name Link
Latest commit 31387afb1704238ef261ad97ba89298e9523b549
Latest deploy log https://app.netlify.com/sites/storybook-bloom-dev/deploys/64e7713aad2ca200085c000d
Deploy Preview https://deploy-preview-121--storybook-bloom-dev.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 12.0.20 :tada:

The release is available on:

Your semantic-release bot :package::rocket: