Closed jaredcwhite closed 1 year ago
Name | Link |
---|---|
Latest commit | 92308d54676b4ec6df39bcebb3cbd45de09ed7e2 |
Latest deploy log | https://app.netlify.com/sites/storybook-ui-seeds/deploys/644182a964b2620008849cbe |
Deploy Preview | https://deploy-preview-21--storybook-ui-seeds.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
@slowbot @emilyjablonski All right, I've updated some tokens and all the heading classes to reflect the latest design recs. Let me know if that looks good to you!
https://github.com/bloom-housing/ui-seeds/blob/heading-component/src/global/tokens/fonts.scss https://github.com/bloom-housing/ui-seeds/blob/heading-component/src/global/text.scss https://deploy-preview-21--storybook-ui-seeds.netlify.app/?path=/story/text-heading--headings
@jaredcwhite I guess I was hoping we would not lose the semantic text size tokens, but instead, update the heading classes. Is that still possible or does this feel cleaner to folks?
I think the body, label and caption tokens were still nice
@slowbot yes, the body/label/caption font size tokens and text classes (text-body
/text-label
/text-caption
) are still present after the changes.
:tada: This PR is included in version 1.4.0 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
This PR addresses #16 and #8 (and also #18)
Description
The
Heading
andHeadingGroup
components have been added to the design library.How Can This Be Tested/Reviewed?
Storybook examples here: https://deploy-preview-21--storybook-ui-seeds.netlify.app/?path=/story/text-heading--headings and here: https://deploy-preview-21--storybook-ui-seeds.netlify.app/?path=/story/text-heading-group--heading-groups
Checklist: