bloom-housing / ui-seeds

Bloom's affordable housing design system
Apache License 2.0
1 stars 1 forks source link

UISeeds - Card Component #22

Closed jaredcwhite closed 1 year ago

jaredcwhite commented 1 year ago

QA Notes:

Evaluate the documentation: https://zeroheight.com/5e69dd4e1/p/25e5b8-card/b/93a6d7

Reference:


Copied over from bloom-housing/bloom#3338

Emily: Transfer the Card component from UIC to UISeeds. (Audit Link) (Notion Docs Link)

Jesse: Design Spec https://www.figma.com/file/SsYt5YsgbmOPbwr5Qk2RKB/bloom-core-library?node-id=3340%3A11137&t=aTDMqb8SbV7GhoAV-1

sarahlazarich commented 1 year ago

@slowbot any luck with QA here?

slowbot commented 1 year ago

@jaredcwhite

Are we not handling alignment at the component level and instead making that a layout property?

jaredcwhite commented 1 year ago

@slowbot yeah that's a good question. My preference would be that it's handled separately from what the Card component itself provides. Could be as simple as having a utility class like text-center which would just get applied to some content, or maybe we consider it as part of more formal content sectioning/typography. It feels awkward to me that Card or a subcomponent therein would have an left/center/right alignment property. Thoughts @emilyjablonski ?

slowbot commented 1 year ago

@emilyjablonski @jaredcwhite closing this ticket and we can continue the discussion in our regular meeting