UISeeds - Link Component

bloom-housing / ui-seeds

Shared user interface components for Bloom affordable housing system

Apache License 2.0

1 stars 1 forks source link

UISeeds - Link Component #24

Closed emilyjablonski closed 11 months ago

emilyjablonski commented 1 year ago

Description

Create a new link component in UISeeds

Links

Eng Audit Zero height Docs

Additional Details

Will more than likely share some style attributes with the button component https://github.com/bloom-housing/bloom/issues/3336

Acceptance Criteria

Figma Design Spec

QA review/instructions

Uptake Scope

What's in and out

jaredcwhite commented 1 year ago

As discussed in a grooming meeting, we'll want to provide basic styling of a tags as we currently do in ui-components, and then provide the additional styling functionality through use of our Link component.

We'll need to discuss separately if this means for the Next.js apps, we always import and use the Seeds Link component rather than Next's own Link component as a matter of course (and bring over the same NavigationContext convention?)

emilyjablonski commented 1 year ago

“If the Link opens to an external website or document, include an icon or text to indicate this to the user”
- When we uptake should we adopt this?

slowbot commented 1 year ago

Default styles handled with reset, additional styles styled with prose style for markdown
Update docs for default styles
Note uptake scope for offsite links

slowbot commented 11 months ago

@jaredcwhite I don't see completed zeroheight docs for this? Am I missing something

https://exygy.zeroheight.com/styleguide/s/100882/p/77fb4a-link/b/93a6d7

jaredcwhite commented 11 months ago

@slowbot Indeed you are not—I forgot to update post-merge. Will do so now!

slowbot commented 11 months ago

@jaredcwhite LGTM