search

bloom-housing / ui-seeds

Shared user interface components for Bloom affordable housing system
Apache License 2.0
1 stars 1 forks source link

Form Error Message #3

Closed jaredcwhite closed 1 year ago

jaredcwhite commented 1 year ago

Issue: https://github.com/bloom-housing/bloom/issues/3241

netlify[bot] commented 1 year ago

Deploy Preview for storybook-ui-seeds ready!

Name Link
Latest commit 43faf61bf3fb9468990e568bad8c6e16e28164db
Latest deploy log https://app.netlify.com/sites/storybook-ui-seeds/deploys/63f57648114a6c000840d477
Deploy Preview https://deploy-preview-3--storybook-ui-seeds.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

jaredcwhite commented 1 year ago

OK, this feels pretty solid now I think. @ludtkemorgan @emilyjablonski I was wondering how we want to handle per-component token naming. In the past I had sometimes done a more simple naming scheme without spelling out the whole component name, but maybe we should make it more clear? (So for example this time I specified something like --form-error-message-font-size.) Jessie at one time had suggested all our tokens start with a --bloom prefix, but I'm not sure if we need that per-component.

ludtkemorgan commented 1 year ago

OK, this feels pretty solid now I think. @ludtkemorgan @emilyjablonski I was wondering how we want to handle per-component token naming. In the past I had sometimes done a more simple naming scheme without spelling out the whole component name, but maybe we should make it more clear? (So for example this time I specified something like --form-error-message-font-size.) Jessie at one time had suggested all our tokens start with a --bloom prefix, but I'm not sure if we need that per-component.

@jaredcwhite I don't have a strong opinion. It would be nice if it's not too long of a name but also we want it to be clear what it does just from its name. The bloom prefix could help make it certain that there aren't duplicates tokens between bloom and other things (I'm more thinking of future cases by consumers of ui-seeds), but I don't really think that chance is likely.

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 1.2.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: