bloom-housing / ui-seeds

Shared user interface components for Bloom affordable housing system
Apache License 2.0
1 stars 1 forks source link

UISeeds - Grid Component #32

Closed jaredcwhite closed 1 year ago

jaredcwhite commented 1 year ago

QA Notes:

Evaluate the documentation: https://zeroheight.com/5e69dd4e1/p/76600d-grid/b/93a6d7 Storybook link: https://storybook-ui-seeds.netlify.app/?path=/story/layout-grid--grid-example

Reference:


Copied over from bloom-housing/bloom#3339. @emilyjablonski:

Transfer the GridSection component from UIC to UISeeds (rename it to Grid!). (Audit Link) (Figma Docs Link)


sarahlazarich commented 1 year ago

@jaredcwhite who will QA this? can you please tag them?

jaredcwhite commented 1 year ago

@sarahlazarich Yeah I guess @slowbot can evaluate it from the design side. Otherwise may have to wait until next week.

slowbot commented 1 year ago

@jaredcwhite

  1. Should we create a new tab for Usage Notes? I don't want these details to get lost
  2. It's a small detail but can we match the grid cell styles in the Figma doc? The grey boxes and text seem to recede
  3. Can we be specific in the docs about breakpoint the gap size shifts? Is this set by a variable?
  4. Can we treat all code samples the same for the component? Can columns use generic styling?
jaredcwhite commented 1 year ago

There's something weird going on with the grid examples at the moment, will investigateā€¦and yeah I can use the more obvious accent colors from Figma.