bloom-housing / ui-seeds

Shared user interface components for Bloom affordable housing system
Apache License 2.0
1 stars 1 forks source link

UISeeds - Button Component #36

Closed jaredcwhite closed 1 year ago

jaredcwhite commented 1 year ago

Copied over from https://github.com/bloom-housing/bloom/issues/3336

(Audit Link) (Notion Docs Link)

Design Spec https://www.figma.com/file/SsYt5YsgbmOPbwr5Qk2RKB/bloom-core-library?type=design&node-id=3303-10456&t=tdoCIOYsnlmcWDg9-0

zeroheight https://exygy.zeroheight.com/styleguide/s/100882/p/7607be-button/b/93a6d7

Spec notes as of May 10:

The dual cases of Button using <button> or using <a href> under the hood will now be handled by this single Button components. The separate Link component will not handle links which visually appear button-like.


Previously:

slowbot commented 1 year ago

@jaredcwhite updated docs to reflect "text button" and "link button" variants

slowbot commented 1 year ago

@jaredcwhite Looks like we had a disconnect on the "text button" variant

jaredcwhite commented 1 year ago

Yeah once the PR is merged, the PR author (aka me) should go update zeroheight, which I forgot. Oops, will fix.

Regarding your other feedback, I'm confused what you're asking me to change? The variant prop to text rather than borderless-text? The font sizes are all the same as the other button variants (sm, md, lg), but I can make large equal medium for text buttons if there shouldn't be large.

Regarding padding, I thought these might be placed inline alongside other buttons so they'd need the same padding/dimensions (and I think that's how Shoelace works). But if not, I can remove the padding.

slowbot commented 1 year ago
  1. I suggest renaming the variant
  2. We don't use the large link size anywhere in the app
  3. I would remove the padding for now, the use cases I see don't use it
jaredcwhite commented 1 year ago

@slowbot All right, this should be resolved now in #58. Let me know if that looks good to you.

slowbot commented 1 year ago

Looks to me! @jaredcwhite