Closed jaredcwhite closed 1 year ago
Name | Link |
---|---|
Latest commit | b533647cbed676cfdccfdc672cade2df4627a76f |
Latest deploy log | https://app.netlify.com/sites/storybook-ui-seeds/deploys/64ae1af14a136e0008299c17 |
Deploy Preview | https://deploy-preview-42--storybook-ui-seeds.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
@emilyjablonski Other than the question of the link icon being optional or default, I've addressed your recommendations.
Note: I'd forgotten to prefix the component-level tokens with button-
to stay in line with existing Seeds conventions, so I've updated the PR with that.
:tada: This PR is included in version 1.8.0 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
LGTM!
Issue Overview
This PR addresses #36
Description
This PR adds a Button component which covers the following use cases:
<button>
which defaults to typebutton
, or can be set to typesubmit
(orreset
) for form submissions<a href="…">
which links to an internal page (but still visually looks like a button)<a href="…" target="_blank">
which links to an external page and shows a box+arrow iconIn addition, there's a "borderless" variant which lets a button appear visually as a link.
How Can This Be Tested/Reviewed?
Storybook link: https://deploy-preview-42--storybook-ui-seeds.netlify.app/?path=/story/actions-button--default-button
Checklist: