bloom-housing / ui-seeds

Shared user interface components for Bloom affordable housing system
Apache License 2.0
1 stars 1 forks source link

feat: add Button component #42

Closed jaredcwhite closed 1 year ago

jaredcwhite commented 1 year ago

Issue Overview

This PR addresses #36

Description

This PR adds a Button component which covers the following use cases:

In addition, there's a "borderless" variant which lets a button appear visually as a link.

How Can This Be Tested/Reviewed?

Storybook link: https://deploy-preview-42--storybook-ui-seeds.netlify.app/?path=/story/actions-button--default-button

Checklist:

netlify[bot] commented 1 year ago

Deploy Preview for storybook-ui-seeds ready!

Name Link
Latest commit b533647cbed676cfdccfdc672cade2df4627a76f
Latest deploy log https://app.netlify.com/sites/storybook-ui-seeds/deploys/64ae1af14a136e0008299c17
Deploy Preview https://deploy-preview-42--storybook-ui-seeds.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

jaredcwhite commented 1 year ago

@emilyjablonski Other than the question of the link icon being optional or default, I've addressed your recommendations.

jaredcwhite commented 1 year ago

Note: I'd forgotten to prefix the component-level tokens with button- to stay in line with existing Seeds conventions, so I've updated the PR with that.

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 1.8.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

slowbot commented 1 year ago

LGTM!