bloom-housing / ui-seeds

Shared user interface components for Bloom affordable housing system
Apache License 2.0
1 stars 1 forks source link

UISeeds - Message + Alert + Toast Components #5

Closed emilyjablonski closed 1 year ago

emilyjablonski commented 1 year ago

Transfer the AlertBox component from UIC to UISeeds. (Audit Link) (Notions Docs Link) (Figma)

AlertBox already has V2 styling. We should make a few changes to the component on transfer:

Three use cases:

Set of semantic colors that are paired with a suggested icon if the icon is enabled (so would pass semantic color + icon enabled defaults to suggested based on semantic color + potential custom icon to override the default)

slowbot commented 1 year ago

@emilyjablonski Adding docs for Message and Toast

https://www.notion.so/exygy/Message-c1d0cf55676743b3b7e97a7851a0ef37?pvs=4 https://www.notion.so/exygy/Toast-fbe5991a0efa498a9b5a1d1b2312ef99?pvs=4

slowbot commented 1 year ago

@jaredcwhite @emilyjablonski Adding color and measurement specs https://www.figma.com/file/SsYt5YsgbmOPbwr5Qk2RKB/bloom-core-library?node-id=3336%3A11517&t=USnlkB54y9cqUwqI-1

sarahlazarich commented 1 year ago

Based on our convo in core sync, it seems like the designer that authored the proposal should QA these component development tickets -- @slowbot in this case I think!

slowbot commented 1 year ago

@sarahlazarich @jaredcwhite Is part of this process having the zeroheight docs ready?

jaredcwhite commented 1 year ago

@slowbot oh yeah, my bad. I should have updated the docs once I merged in the PR. Will get on it.

slowbot commented 1 year ago

@jaredcwhite Is there a reason to display the css style here on Message? Is that a dependency of using custom icon? If its an implementation detail I would opt to remove it.

image

slowbot commented 1 year ago

Other than this detail, it looks good to me. @jaredcwhite