bloom-housing / ui-seeds

Shared user interface components for Bloom affordable housing system
Apache License 2.0
1 stars 1 forks source link

fix: prevent empty messaging #50

Closed ColinBuyck closed 1 year ago

ColinBuyck commented 1 year ago

Issue Overview

This PR partially addresses https://github.com/bloom-housing/bloom/issues/3434

Description

As part of the uptake, I noticed that the toast component would still render without a message defined and required me to write out successToastMessage && {successToastMessage} for every instance. This change should help reduce clutter in uptake across all message types and preserve the intention of conveying a message.

How Can This Be Tested/Reviewed?

This can be tested by starting up the storybook and removing the children to any component that extends common message and it will not render as opposed to rendering empty.

Checklist:

netlify[bot] commented 1 year ago

Deploy Preview for storybook-ui-seeds ready!

Name Link
Latest commit cc61b4f7c7b545fd69fdb2b5191d41f5af02490c
Latest deploy log https://app.netlify.com/sites/storybook-ui-seeds/deploys/649e14da4feb6a0008566ec4
Deploy Preview https://deploy-preview-50--storybook-ui-seeds.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 1.7.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket: